Welcome to CRUX bug tracking.

FS#608 - why not switch from libungif to giflib?

Attached to Project: CRUX
Opened by Danny Rawlins (Romster) - Saturday, 19 June 2010, 08:41 GMT
Last edited by Jose V Beneyto (sepen) - Monday, 22 October 2012, 11:39 GMT
Task Type Bug Report
Category ports → core/opt
Status Closed
Assigned To Jose V Beneyto (sepen)
Operating System Linux
Severity Low
Priority Normal
Reported Version 2.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No


Why are you still using libungif when the patent no longer exists on LZW compression algorithm, now you can use giflib.
This task depends upon

Closed by  Jose V Beneyto (sepen)
Monday, 22 October 2012, 11:39 GMT
Reason for closing:  Fixed
Additional comments about closing:  Thanks for your reports
Comment by Jose V Beneyto (sepen) - Tuesday, 04 September 2012, 14:07 GMT
I attached an updated Pkgfile
   Pkgfile (0.5 KiB)
Comment by Jose V Beneyto (sepen) - Tuesday, 02 October 2012, 21:23 GMT
I suggest to remove opt/libungif for opt/giflib but that also requires more changes to dependent ports:


To minimize the impact we could append that line: 'giflib: libungif' to /var/lib/pkg/prt-get.aliases

And for the future 2.8 iso I attached a patch for setup-helper script

Comment by Juergen Daubert (jue) - Thursday, 04 October 2012, 09:16 GMT
I'd suggest to do this only for CRUX 2.8. Note, the addition to setup-helper only makes sense if we ship giflib with our ISO.
Comment by Jose V Beneyto (sepen) - Thursday, 04 October 2012, 11:35 GMT
Yeah, you're right, setup-helper is not required since libungif/giflib is not listed in packages.opt, my bad.
And yes, the idea is to do it only for 2.8 branches.
Comment by Jose V Beneyto (sepen) - Saturday, 06 October 2012, 06:58 GMT
Ok Juergen, now I see that opt/emacs is not part of 2.8 branches ;D
Comment by Ryan Mullen (rmull) - Friday, 19 October 2012, 15:24 GMT
For what it's worth, opt/imlib2 (1.4.5) does not build correctly with rmull/giflib (5.0.1 at the time of this comment):

loader_gif.c: In function 'load':
loader_gif.c:39:4: error: too few arguments to function 'DGifOpenFileHandle'
/usr/include/gif_lib.h:178:14: note: declared here
Comment by Jose V Beneyto (sepen) - Monday, 22 October 2012, 11:39 GMT
After reading seems that DGifOpenFileHandle requires ErrorCode to be passed as argument.
To build I added a small fix to imlib2/Pkgfile[1]