CRUX

Welcome to CRUX bug tracking.
Tasklist

FS#221 - Warn on new files in .footprint

Attached to Project: CRUX
Opened by Danny Rawlins (Romster) - Tuesday, 12 February 2008, 03:35 GMT
Last edited by Tilman Sauerbeck (tilman) - Thursday, 27 May 2010, 19:21 GMT
Task Type Improvement
Category tools → pkgutils
Status Closed
Assigned To Tilman Sauerbeck (tilman)
Operating System Linux
Severity Low
Priority Normal
Reported Version 2.4
Due in Version 2.7
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Warn on new files to .footprint but don't update .footprint and still error on missing files.
This task depends upon

Closed by  Tilman Sauerbeck (tilman)
Thursday, 27 May 2010, 19:21 GMT
Reason for closing:  Fixed
Additional comments about closing:  Thanks for the review. I pushed the patch.
Comment by Mykhailo Kolesnyk (mike_k) - Tuesday, 12 February 2008, 10:26 GMT
While some people will find such a feature useful - it might require a new option (and command line switch) to activate this behavior and to keep the current as default. Something like PKGMK_IGNORE_NEW_FILES_IN_FOOTPRINT_BLAH_BLAH.
It also implies that port maintainers should try to get the smallest possible footprint, but there is currently no preferred (documented) way to chroot, etc...
Comment by Juergen Daubert (jue) - Wednesday, 13 February 2008, 14:41 GMT Comment by Johannes Winkelmann (jw) - Wednesday, 14 May 2008, 22:22 GMT
I'd suggest to add an option to pkgmk (maybe -iN) and leave it off by default, since typically, if you run pkgmk from the command line it's not a big difference, and if you already take the time to build a single package it's certainly not too much to ask to check the actual error message.
The main benefit should be in depinst/sysup transactions, so if such a command line switch would be in place we could add an option to prt-get.

It also nicely separates the "packaging" use case from the "user install" one; the former should probably care about the error (and use pkgmk), the later wants to get the packages installed with as little extra effort as needed.
Comment by Danny Rawlins (Romster) - Thursday, 15 May 2008, 02:47 GMT
I'll think of a revised patch for this that will add in signals too for prt-get to use. The main pourpose was to avoid having to use the ignore footprint option in prt-get but still offer some protection for when there is missing files. I'll get back with a better patch for this.
Comment by Johannes Winkelmann (jw) - Thursday, 15 May 2008, 06:26 GMT
As a note for whoever will adapt this to the regular pkgutils, it should probably be faster to use "(e)grep -l" to stop after the first match, especially for large differences. Not sure if it makes a real difference for typical mismatches, but it's still more efficient
Comment by Johannes Winkelmann (jw) - Wednesday, 04 March 2009, 17:58 GMT
A patched pkgutils port is available from http://jw.smts.ch/files/crux/ports/pkgutils. It implements the -in switch mentioned in my previous comment, as well as symbolic error codes.
Comment by Juergen Daubert (jue) - Monday, 14 December 2009, 09:18 GMT
See the following thread with the discussion about that, including two patches which apply clean to latest version of pkgutils.

http://thread.gmane.org/gmane.linux.distributions.crux.general/4066/focus=4197
Comment by Juergen Daubert (jue) - Thursday, 08 April 2010, 10:26 GMT
For convenience I've attached the two patches from Johannes (pkgmk-error_codes and pkgmk-ignore_new) here. Please apply the pkgmk-ignore_new patch first.
Comment by Tilman Sauerbeck (tilman) - Sunday, 23 May 2010, 16:06 GMT
I pushed the ignore-new patch.

Re. the error-codes patch: it would be nice to have documentation for the exit codes in the man page.
Comment by Tilman Sauerbeck (tilman) - Monday, 24 May 2010, 11:59 GMT
Here's a patch that adds documentation for the exit codes. Please review.
Comment by Juergen Daubert (jue) - Thursday, 27 May 2010, 10:19 GMT
Thanks, the exit-codes patch looks fine to me, please apply.

Loading...