CRUX

Welcome to CRUX bug tracking.
Tasklist

FS#1638 - pkgadd: lzip support

Attached to Project: CRUX
Opened by Fun (fun) - Sunday, 01 April 2018, 08:40 GMT
Last edited by Fredrik Rinnestam (frinnst) - Tuesday, 10 April 2018, 21:19 GMT
Task Type Bug Report
Category tools → pkgutils
Status Closed
Assigned To Fredrik Rinnestam (frinnst)
Operating System CRUX
Severity Low
Priority Normal
Reported Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The attached patch makes "PKGMK_COMPRESSION_MODE=lz" work.
   0001-pkgadd-complete-the-bzip... (1.4 KiB)
This task depends upon

Closed by  Fredrik Rinnestam (frinnst)
Tuesday, 10 April 2018, 21:19 GMT
Reason for closing:  Implemented
Comment by Fredrik Rinnestam (frinnst) - Monday, 02 April 2018, 12:16 GMT
Last I looked, libarchive cant compress lz. When did that change?

--edit
Nevermind, must be confusing libarchive with some other project i was looking at
Comment by Fun (fun) - Monday, 02 April 2018, 12:36 GMT
You might be right. I think I've rebuit libarchive while opt/lzip was installed.
Comment by Fredrik Rinnestam (frinnst) - Monday, 02 April 2018, 12:37 GMT
The commit message looks a bit confusing. Wanna clean it up and resubmit the patch?
Comment by Fun (fun) - Monday, 02 April 2018, 12:42 GMT
Sure. I hope to do this tonight and check the libarchive build too.
Comment by Fun (fun) - Monday, 02 April 2018, 22:03 GMT
Attached the new patch.

I've rebuilt libarchive in a container and 'pkgadd' (with this patch) works with .lz files. It looks like lzip and xz share some code (in libarchive). Probably this is why it can handle lzip files even without opt/lzip.
   0001-pkgadd-add-lzip-support.... (1.3 KiB)
Comment by Fun (fun) - Monday, 02 April 2018, 22:06 GMT
This patch will close this ticket too :D
   0001-pkgadd-add-lzip-support.... (1.3 KiB)
Comment by Fredrik Rinnestam (frinnst) - Sunday, 08 April 2018, 14:45 GMT
So, you might have wondered why I asked you to redo the commit? That's because I was wondering why *you* dropped bz2 support. Looking back at the commit history I noticed that one of my commits actually dropped it. I cant for the life of me remember *why* I dropped it. I think it was never supposed to be committed and i'll revert it shortly.

Loading...