CRUX

Welcome to CRUX bug tracking.
Tasklist

FS#1538 - qemu ports have conflicting files

Attached to Project: CRUX
Opened by John Vogel (j_v) - Wednesday, 22 November 2017, 19:14 GMT
Task Type Bug Report
Category ports → core/opt
Status New
Assigned To No-one
Operating System CRUX
Severity Low
Priority Low
Reported Version 3.3
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

There are three different ports in the opt collection for qemu related packages:
qemu
qemu-all
qemu-agent

1) Both of qemu and qemu-all ports package usr/bin/qemu-ga, which should probably be
relegated to qemu-agent port only.
2) Much of the qemu port is duplicated in the qemu-all port. Perhaps the qemu-all port
can depend on the qemu port, then the conflicting files be relegated to qemu port.
Then, the qemu-all port would only actually add the additional files built due to
the additionally supported architectures.

I will submit patches when I have more time.
This task depends upon

Comment by Fun (fun) - Wednesday, 22 November 2017, 21:22 GMT
I like that CRUX doesn't split packages, instead it has "light" and "heavy" versions.

In this case: qemu-agent is the port you install when you use the system as a guest, qemu version is a bigger version, having the device manager to run guests in addition to the agent, and qemu-all has all of that, but for all platforms.

Most users will install qemu, and those running linux guests will want the agent too, and it's nicer they don't have to install another port (the agent).
Comment by John Vogel (j_v) - Thursday, 23 November 2017, 03:07 GMT
I guess I can see you point and while I don't quite agree, I think there are issues here just the same.
If what you are saying is that one should be able to pick any one of the three qemu ports for their needs,
then there is a problem in that there is a conflict by only providing the qemu-agent rc script in the
qemu-agent port, but providing the qemu-ga binary in all three so that the usr/bin/qemu-ga file will cause
a conflict. The qemu-ga manpage is missing from all three ports.

Personally, I think that having the "heavy" version depend on the "light" version then filling in the gaps
in the "heavy" version makes sense. But I guess it's not that big of a deal. I already have a private fork
of the qemu ports because I also build static versions for use in cross-arch user-mode chroots/containers,
so no big deal.
Comment by Fun (fun) - Thursday, 23 November 2017, 07:20 GMT
Sometimes I don't agree with myself either :))

Removing the agent from qemu and qemu-all, and removing qemu/x86_64 from qemu-all will make these ports complement each other. This is the way the xxx-32 ports do with their include/header files. Also, most of the users (having/installing qemu port) won't be affected (except for those in need of the agent binary, who will have to install the qemu-agent). You will also get ride of the override errors when you migrate from one port to another without uninstalling the previous one first. Having qemu-all depend on qemu, and qemu depend on qemu-agent will make the install smooth, except for the first upgrade.

Still ... :D
Comment by John Vogel (j_v) - Thursday, 23 November 2017, 23:47 GMT
I guess I can see you point and while I don't quite agree, I think there are issues here just the same.
If what you are saying is that one should be able to pick any one of the three qemu ports for their needs,
then there is a problem in that there is a conflict by only providing the qemu-agent rc script in the
qemu-agent port, but providing the qemu-ga binary in all three so that the usr/bin/qemu-ga file will cause
a conflict. The qemu-ga manpage is missing from all three ports.

Personally, I think that having the "heavy" version depend on the "light" version then filling in the gaps
in the "heavy" version makes sense. But I guess it's not that big of a deal. I already have a private fork
of the qemu ports because I also build static versions for use in cross-arch user-mode chroots/containers,
so no big deal.
Comment by John Vogel (j_v) - Thursday, 23 November 2017, 23:49 GMT
Not sure how my comment got added twice. A apologize for the added noise.

Loading...