CRUX-Contrib

Contributed ports (contrib collection)
Tasklist

FS#1814 - libreoffice fails to build

Attached to Project: CRUX-Contrib
Opened by Erich Eckner (deepthought) - Sunday, 28 June 2020, 12:21 GMT
Last edited by Danny Rawlins (Romster) - Tuesday, 30 June 2020, 09:39 GMT
Task Type Bug Report
Category ports - contrib
Status Closed
Assigned To Danny Rawlins (Romster)
Tim Biermann (tb)
Operating System CRUX
Severity Medium
Priority Normal
Reported Version 3.5
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

it fails (on my machine) with:

/usr/ports/work/libreoffice/src/libreoffice-6.4.5.2/vcl/qt5/Qt5Frame.cxx:53:10: fatal error: QtX11Extras/QX11Info: No such file or directory
#include <QtX11Extras/QX11Info>

I already did a `sudo prt-get update -fr $(prt-get quickdep libreoffice), but it did not help. Please find attached a full build log.

regards,
Erich
This task depends upon

Closed by  Danny Rawlins (Romster)
Tuesday, 30 June 2020, 09:39 GMT
Reason for closing:  Fixed
Additional comments about closing:  I made it a hard dependency, to make it a soft dependency for qtx11extras would require extensive rework.
Comment by Tim Biermann (tb) - Sunday, 28 June 2020, 13:10 GMT
Hi Erich,
I noticed that before, it seems to pop up everywhere, first though with kvantum (for me).
Please read attached commit/README, follow these instructions and report back if it solves the problem for you. https://crux.nu/gitweb/?p=ports/contrib.git;a=commit;h=9ffe24156ff7de9cdc01b2de29a88c087120f6ed

In general:
This seems to be a new behaviour starting with qt5 version 5.15.0. It didn't need that before that.

I am seeing these options:
a) making it a soft dependency of qt5, adding it to a README
b) creating an individual port for X11Extras that all ports that need it can depend on
c) making it a hard dependency of qt5

IMO:
a) is prone to provoke user errors (who reads a readme, right?) also prt-get doesn't support handling OPTIONAL dependencies
b) might work fine, I would say it depends on the number of ports that would need to depend on it. If they are less than half of the total ports that depend on qt5, it might be a good way?
c) if b) is useless as too many ports depend on it now, this would be the best option
d) maybe there is something else wrong that I don't think about right now

Edit: co-assigning romster as well to aid with the qt5 related part of this issue
Comment by Erich Eckner (deepthought) - Sunday, 28 June 2020, 18:05 GMT
I'm in favour of option b, too, because that would have meant, I would have found the issue on my own: I did a `prt-get fsearch` for the missing file, but nothing turned up.
I'm currently in the process of recompiling qt5 - I'll report back, when it's done.
Comment by Erich Eckner (deepthought) - Monday, 29 June 2020, 04:47 GMT
yes, it works! Thank you!

Loading...